Skip to content

Update AGP to 8.9 and Gradle to 8.13 and fix new issues#2003

Merged
bidetofevil merged 2 commits intomainfrom
hho/agp-upgrade-fix
Mar 8, 2025
Merged

Update AGP to 8.9 and Gradle to 8.13 and fix new issues#2003
bidetofevil merged 2 commits intomainfrom
hho/agp-upgrade-fix

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 7, 2025

Goal

Update AGP and Gradle and fix the issues identified in the upgrades

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Mar 7, 2025

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the tests are fixed

@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from 212c5bc to e8c1d55 Compare March 7, 2025 14:48
@bidetofevil bidetofevil force-pushed the hho/storage-faking branch 2 times, most recently from 01f616a to 0ff007b Compare March 7, 2025 15:01
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from e8c1d55 to 020c534 Compare March 7, 2025 15:02
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from 020c534 to 8783a98 Compare March 7, 2025 15:19
@bidetofevil bidetofevil force-pushed the hho/storage-faking branch 2 times, most recently from 73fe64d to d26d34b Compare March 7, 2025 17:26
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from 8783a98 to 12c8d25 Compare March 7, 2025 17:27
@bidetofevil bidetofevil changed the base branch from hho/storage-faking to graphite-base/2003 March 7, 2025 22:10
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from 12c8d25 to ee537c0 Compare March 7, 2025 22:12
@bidetofevil bidetofevil changed the base branch from graphite-base/2003 to hho/storage-faking March 7, 2025 22:12
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from 7f3c41b to eaefe23 Compare March 7, 2025 22:24
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from eaefe23 to 266f101 Compare March 8, 2025 00:52
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch 2 times, most recently from 6a39941 to 76654b6 Compare March 8, 2025 01:02
@bidetofevil bidetofevil force-pushed the hho/storage-faking branch 2 times, most recently from 1b12c23 to 5d13fb2 Compare March 8, 2025 01:12
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch 2 times, most recently from d21acdd to d34cfe3 Compare March 8, 2025 05:59
@bidetofevil bidetofevil changed the base branch from hho/storage-faking to graphite-base/2003 March 8, 2025 06:17
@bidetofevil bidetofevil force-pushed the hho/agp-upgrade-fix branch from d34cfe3 to acefc69 Compare March 8, 2025 06:17
@bidetofevil bidetofevil changed the base branch from graphite-base/2003 to main March 8, 2025 06:18
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 8, 2025

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.38%. Comparing base (c58f925) to head (7fcead3).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt 33.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (33.33%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2003      +/-   ##
==========================================
- Coverage   85.39%   85.38%   -0.01%     
==========================================
  Files         482      482              
  Lines       11234    11234              
  Branches     1686     1686              
==========================================
- Hits         9593     9592       -1     
  Misses        902      902              
- Partials      739      740       +1     
Files with missing lines Coverage Δ
...nternal/capture/metadata/EmbraceMetadataService.kt 83.78% <ø> (ø)
...nal/network/http/EmbraceHttpUrlConnectionImpl.java 100.00% <ø> (ø)
...al/network/http/EmbraceHttpsUrlConnectionImpl.java 100.00% <ø> (ø)
...nal/network/http/EmbraceUrlConnectionDelegate.java 84.06% <ø> (ø)
...ndroid/embracesdk/internal/ui/FirstDrawDetector.kt 25.39% <33.33%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bidetofevil bidetofevil merged commit 171a46c into main Mar 8, 2025
10 of 11 checks passed
Copy link
Copy Markdown
Contributor Author

Merge activity

  • Mar 8, 1:38 AM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil deleted the hho/agp-upgrade-fix branch March 8, 2025 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants