Skip to content

Further simplify the usage of the integration test rule#2001

Merged
bidetofevil merged 1 commit intomainfrom
hho/further-test-rule-simp
Mar 7, 2025
Merged

Further simplify the usage of the integration test rule#2001
bidetofevil merged 1 commit intomainfrom
hho/further-test-rule-simp

Conversation

@bidetofevil
Copy link
Copy Markdown
Contributor

@bidetofevil bidetofevil commented Mar 6, 2025

Goal

Instantiate fakes we always use within the setup interface and expose them for reading/altering. In addition, we don't prepopulate native symbols and instead rely on the tests to do the setup..

@bidetofevil bidetofevil force-pushed the hho/reduce-fake-workers branch from 22b3ab4 to 1dd2058 Compare March 6, 2025 23:19
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from 307b93a to 4b472de Compare March 6, 2025 23:20
@bidetofevil bidetofevil marked this pull request as ready for review March 6, 2025 23:45
@bidetofevil bidetofevil requested a review from a team as a code owner March 6, 2025 23:45
@bidetofevil bidetofevil requested review from fractalwrench and removed request for a team March 6, 2025 23:45
@bidetofevil bidetofevil force-pushed the hho/reduce-fake-workers branch from 1dd2058 to e1134e0 Compare March 6, 2025 23:54
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from 4b472de to 40b2f28 Compare March 6, 2025 23:54
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.38%. Comparing base (c8284b3) to head (b60ed2d).
Report is 3 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2001      +/-   ##
==========================================
- Coverage   85.41%   85.38%   -0.03%     
==========================================
  Files         482      482              
  Lines       11234    11234              
  Branches     1686     1686              
==========================================
- Hits         9595     9592       -3     
  Misses        901      901              
- Partials      738      741       +3     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@fractalwrench fractalwrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from f83ecfb to b262c58 Compare March 7, 2025 14:48
@bidetofevil bidetofevil force-pushed the hho/reduce-fake-workers branch 3 times, most recently from 1244467 to c8284b3 Compare March 7, 2025 15:01
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from b262c58 to 00d6ff9 Compare March 7, 2025 15:01
@bidetofevil bidetofevil changed the base branch from hho/reduce-fake-workers to graphite-base/2001 March 7, 2025 15:18
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from 00d6ff9 to 9696dd7 Compare March 7, 2025 15:18
@bidetofevil bidetofevil changed the base branch from graphite-base/2001 to main March 7, 2025 15:19
@bidetofevil bidetofevil force-pushed the hho/further-test-rule-simp branch from 9696dd7 to b60ed2d Compare March 7, 2025 15:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 7, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link
Copy Markdown
Contributor Author

bidetofevil commented Mar 7, 2025

Merge activity

  • Mar 7, 12:26 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Mar 7, 12:26 PM EST: A user merged this pull request with Graphite.

@bidetofevil bidetofevil merged commit 43b82f7 into main Mar 7, 2025
11 checks passed
@bidetofevil bidetofevil deleted the hho/further-test-rule-simp branch March 7, 2025 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants