Hook up SDK to abandon app startup trace on background#1985
Merged
bidetofevil merged 1 commit intomainfrom Mar 6, 2025
Merged
Conversation
Contributor
Author
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1985 +/- ##
==========================================
+ Coverage 85.33% 85.41% +0.07%
==========================================
Files 482 482
Lines 11233 11234 +1
Branches 1686 1686
==========================================
+ Hits 9586 9595 +9
+ Misses 906 901 -5
+ Partials 741 738 -3
🚀 New features to boost your workflow:
|
54feac0 to
4498a57
Compare
4498a57 to
2e9a92c
Compare
fractalwrench
approved these changes
Mar 5, 2025
| } | ||
| } | ||
|
|
||
| fun createForIntegrationTest(throwOnInternalError: Boolean = true): FakeEmbLogger = FakeEmbLogger( |
Member
There was a problem hiding this comment.
Consider naming this something like fakeLogger() or fakeLoggerForIntegrationTest() - the current name doesn't describe what it does IMO
Contributor
Author
There was a problem hiding this comment.
Good call. I don't actually like how many times this has been invoked, so I may tweak that as well so the overriding cases don't have to create its own logger
2e9a92c to
7dd0046
Compare
790060b to
7488cca
Compare
7dd0046 to
82628af
Compare
7488cca to
11aa234
Compare
82628af to
95372a0
Compare
Contributor
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
95372a0 to
4fdf3f9
Compare
Contributor
Author
4fdf3f9 to
e27e7ec
Compare
This was referenced Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Goal
Register
AppStartupTraceEmitteras service so theonBackground()callback will be invoked when the app background while while app startup is still taking placeAs a result, we had to make sure the integration tests that aren't faking app startup (which means the startup data it collects will be incomplete) ignore internal errors that are generated for when app startup trace cannot be generated.
Similarly, startup traces will now be generated if the conditions are corrected, so those tests that assume that only the logs they create will be exported need to be modified to ignore the internal errors (which are also OTel logs).