Skip to content

docs(rbac): align with revoke/remove confirmation flow and localized scope names#7446

Open
yomybaby wants to merge 2 commits into
05-15-docs_admin_document_prometheus_query_preset_management_uifrom
05-15-docs_rbac_align_with_revoke_remove_confirmation_flow_and_localized_scope_names
Open

docs(rbac): align with revoke/remove confirmation flow and localized scope names#7446
yomybaby wants to merge 2 commits into
05-15-docs_admin_document_prometheus_query_preset_management_uifrom
05-15-docs_rbac_align_with_revoke_remove_confirmation_flow_and_localized_scope_names

Conversation

@yomybaby
Copy link
Copy Markdown
Member

resolves #NNN (FR-MMM)

Checklist: (if applicable)

  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

Copy link
Copy Markdown
Member Author

yomybaby commented May 16, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the RBAC Management user manual pages to reflect recent UI changes in the RBAC role detail flows, including the switch to lightweight popconfirm confirmations for permission removal and user revocation, plus improved clarity around localized scope/permission-type labels.

Changes:

  • Expanded the “Name search” filter description to explain property-dependent input types (selector vs free text).
  • Updated “Add Permission” docs to note localized target display names and localized permission-type labels, and refreshed the referenced screenshot.
  • Revised “Remove Permission” and “Revoke User” sections to describe the new anchored popconfirm confirmation flow and clarify reversibility semantics.

Reviewed changes

Copilot reviewed 4 out of 12 changed files in this pull request and generated 2 comments.

File Description
packages/backend.ai-webui-docs/src/en/rbac_management/rbac_management.md Aligns English RBAC docs with popconfirm-based remove/revoke flows and localized display behavior.
packages/backend.ai-webui-docs/src/ja/rbac_management/rbac_management.md Updates Japanese RBAC docs for new popconfirm remove/revoke UX and refreshed permission modal screenshot.
packages/backend.ai-webui-docs/src/ko/rbac_management/rbac_management.md Updates Korean RBAC docs to use “role/operation” terminology and describe localized labels + popconfirm flows.
packages/backend.ai-webui-docs/src/th/rbac_management/rbac_management.md Updates Thai RBAC docs for localized scope labels, new screenshot, and popconfirm-based remove/revoke descriptions.

Comment thread packages/backend.ai-webui-docs/src/th/rbac_management/rbac_management.md Outdated
Comment thread packages/backend.ai-webui-docs/src/ja/rbac_management/rbac_management.md Outdated
@agatha197 agatha197 force-pushed the 05-15-docs_rbac_align_with_revoke_remove_confirmation_flow_and_localized_scope_names branch from f161984 to c722f31 Compare May 18, 2026 03:54
@agatha197 agatha197 force-pushed the 05-15-docs_admin_document_prometheus_query_preset_management_ui branch from d8003f3 to 0c412ff Compare May 18, 2026 03:54
@agatha197 agatha197 force-pushed the 05-15-docs_rbac_align_with_revoke_remove_confirmation_flow_and_localized_scope_names branch from c722f31 to 8541193 Compare May 18, 2026 05:51
@agatha197 agatha197 force-pushed the 05-15-docs_admin_document_prometheus_query_preset_management_ui branch from 0c412ff to 10d4a7e Compare May 18, 2026 05:51
@agatha197 agatha197 changed the base branch from 05-15-docs_admin_document_prometheus_query_preset_management_ui to graphite-base/7446 May 18, 2026 07:16
@agatha197 agatha197 force-pushed the 05-15-docs_rbac_align_with_revoke_remove_confirmation_flow_and_localized_scope_names branch from 8541193 to 55cb4cf Compare May 18, 2026 07:17
@agatha197 agatha197 force-pushed the graphite-base/7446 branch from 10d4a7e to 908117b Compare May 18, 2026 07:17
@agatha197 agatha197 changed the base branch from graphite-base/7446 to main May 18, 2026 07:17
@agatha197 agatha197 changed the base branch from main to 05-15-docs_admin_document_prometheus_query_preset_management_ui May 18, 2026 07:23
yomybaby added 2 commits May 18, 2026 16:29
…scope names

Part of the recent main-branch docs catch-up plan (Work Item 6).

Source PRs:
- FR-2775 (#7155) localize ROLE_ASSIGNMENT and resolve scope name in permission modal
- FR-2803 (#7229) Korean RBAC: use 역할 (role) / 동작 (action)
- FR-2804 (#7231) Popconfirm-style for reversible RBAC revoke/remove flows
- FR-2828 (#7276) adaptive filter input types for RBAC permission/entity queries

Changes:
- Manage Permissions: scope target now shown as resolved localized name (not raw UUID); permission type label localized.
- Remove a Permission / Revoke Users from a Role: documented Popconfirm-style anchored popup (reversible); not typed-confirm.
- Korean version: 권한 → 역할 for role semantics; 동작 for operation; 세부 권한 retained for fine-grained permissions — matches resources/i18n/ko.json.
- Role List + Permissions tab filter: adaptive input types per selected property.

Updated in all 4 languages (en/ko/ja/th). Screenshots flagged with TODO markers.
Captures all 2 planned screenshots × 4 languages (8 PNGs):
- rbac_permission_modal.png — Add Permission modal with resolved localized scope target + localized Permission Type label (FR-2775)
- rbac_revoke_popconfirm.png — Popconfirm-style anchored confirmation on Revoke User action (FR-2804)

Captured at 2× zoom via Portless dev, per-locale via window.switchLanguage().
Copy link
Copy Markdown
Contributor

@ironAiken2 ironAiken2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L 100~500 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants