Skip to content

docs(model-serving): capture deployment preset edit page screenshot#7460

Open
agatha197 wants to merge 1 commit into
05-15-docs_model-serving_add_deployment_preset_management_documentationfrom
05-18-docs_model-serving_capture_deployment_preset_edit_page_screenshot
Open

docs(model-serving): capture deployment preset edit page screenshot#7460
agatha197 wants to merge 1 commit into
05-15-docs_model-serving_add_deployment_preset_management_documentationfrom
05-18-docs_model-serving_capture_deployment_preset_edit_page_screenshot

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented May 18, 2026

Stacked on #7444 (docs(model-serving): add deployment preset management documentation).

Follow-up polish resolving a screenshot TODO placeholder introduced by #7444 in deployment_presets.md. No separate issue (small completion of #7444's own scope).

Summary

  • Captured deployment_preset_edit_modal.png (the Edit Preset page, prefilled from an existing preset) in all 4 locales (en/ja/ko/th), full-page at 2× zoom. Widened the effective layout so form items sit inside the cards (addressing review feedback that the first capture was too narrow).
  • Removed the corresponding <!-- TODO: Capture screenshot of the deployment preset edit modal ... --> comment in src/{en,ja,ko,th}/model_serving/deployment_presets.md. Image reference and surrounding blank lines unchanged.

Intentionally left as-is

  • deployment_preset_tag_filter.png TODO kept. Deployment presets have no tag concept in the current UI or schema: AdminDeploymentPresetListPage.tsx has zero tag references, AdminDeploymentPresetNodesFragment has no tag field, the schema has no preset tag, and the live admin list columns are Name / Runtime / Image / Replica Count / Created At with no tag chips. The doc's "Filtering by Tags" section + that screenshot describe an unimplemented feature — capturing it would be fabrication.

Notes for #7444 author (doc↔UI mismatches, out of scope here)

  • Create/Edit Preset is a full page (/admin-deployments/deployment-presets/:id/edit), not a modal — but deployment_presets.md and the image filenames (deployment_preset_create_modal.png, deployment_preset_edit_modal.png) say "modal/dialog". Consider renaming + prose fix in docs(model-serving): add Deployment Preset management documentation #7444.
  • The "Filtering by Tags" section and "Filter presets by ... tag" / "Click a tag chip" guidance document a feature absent from the current build.

Test plan

  • src/{en,ja,ko,th}/images/deployment_preset_edit_modal.png renders in the manual.
  • Each locale's screenshot shows that locale's UI strings.
  • Only the tag-filter TODO remains in deployment_presets.md.

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

agatha197 commented May 18, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 marked this pull request as ready for review May 18, 2026 05:43
Copilot AI review requested due to automatic review settings May 18, 2026 05:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes TODO comments for the deployment preset edit modal screenshot across all four locales, now that the screenshot has been captured and added to the user manual.

Changes:

  • Delete the <!-- TODO: Capture screenshot ... --> placeholder in en/ja/ko/th deployment_presets.md
  • Image reference deployment_preset_edit_modal.png remains unchanged

Reviewed changes

Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.

File Description
packages/backend.ai-webui-docs/src/en/model_serving/deployment_presets.md Removed TODO comment for edit modal screenshot
packages/backend.ai-webui-docs/src/ja/model_serving/deployment_presets.md Removed TODO comment for edit modal screenshot
packages/backend.ai-webui-docs/src/ko/model_serving/deployment_presets.md Removed TODO comment for edit modal screenshot
packages/backend.ai-webui-docs/src/th/model_serving/deployment_presets.md Removed TODO comment for edit modal screenshot

@agatha197 agatha197 changed the base branch from 05-15-docs_model-serving_add_deployment_preset_management_documentation to graphite-base/7460 May 18, 2026 06:29
@agatha197 agatha197 deleted the branch 05-15-docs_model-serving_add_deployment_preset_management_documentation May 18, 2026 06:45
@agatha197 agatha197 closed this May 18, 2026
@agatha197 agatha197 reopened this May 18, 2026
@agatha197 agatha197 changed the base branch from graphite-base/7460 to 05-15-docs_model-serving_add_deployment_preset_management_documentation May 18, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants