docs(model-serving): capture deployment preset edit page screenshot#7460
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has required the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Pull request overview
Removes TODO comments for the deployment preset edit modal screenshot across all four locales, now that the screenshot has been captured and added to the user manual.
Changes:
- Delete the
<!-- TODO: Capture screenshot ... -->placeholder in en/ja/ko/thdeployment_presets.md - Image reference
deployment_preset_edit_modal.pngremains unchanged
Reviewed changes
Copilot reviewed 4 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/backend.ai-webui-docs/src/en/model_serving/deployment_presets.md | Removed TODO comment for edit modal screenshot |
| packages/backend.ai-webui-docs/src/ja/model_serving/deployment_presets.md | Removed TODO comment for edit modal screenshot |
| packages/backend.ai-webui-docs/src/ko/model_serving/deployment_presets.md | Removed TODO comment for edit modal screenshot |
| packages/backend.ai-webui-docs/src/th/model_serving/deployment_presets.md | Removed TODO comment for edit modal screenshot |
44f5c32 to
d96a21c
Compare
a98625c to
2acb0f6
Compare

Follow-up polish resolving a screenshot
TODOplaceholder introduced by #7444 indeployment_presets.md. No separate issue (small completion of #7444's own scope).Summary
deployment_preset_edit_modal.png(the Edit Preset page, prefilled from an existing preset) in all 4 locales (en/ja/ko/th), full-page at 2× zoom. Widened the effective layout so form items sit inside the cards (addressing review feedback that the first capture was too narrow).<!-- TODO: Capture screenshot of the deployment preset edit modal ... -->comment insrc/{en,ja,ko,th}/model_serving/deployment_presets.md. Image reference and surrounding blank lines unchanged.Intentionally left as-is
deployment_preset_tag_filter.pngTODO kept. Deployment presets have no tag concept in the current UI or schema:AdminDeploymentPresetListPage.tsxhas zero tag references,AdminDeploymentPresetNodesFragmenthas no tag field, the schema has no preset tag, and the live admin list columns are Name / Runtime / Image / Replica Count / Created At with no tag chips. The doc's "Filtering by Tags" section + that screenshot describe an unimplemented feature — capturing it would be fabrication.Notes for #7444 author (doc↔UI mismatches, out of scope here)
/admin-deployments/deployment-presets/:id/edit), not a modal — butdeployment_presets.mdand the image filenames (deployment_preset_create_modal.png,deployment_preset_edit_modal.png) say "modal/dialog". Consider renaming + prose fix in docs(model-serving): add Deployment Preset management documentation #7444.Test plan
src/{en,ja,ko,th}/images/deployment_preset_edit_modal.pngrenders in the manual.deployment_presets.md.🤖 Generated with Claude Code