Skip to content

docs(FR-2912): document web commands and fix preview:html sidebar scroll#7462

Open
agatha197 wants to merge 4 commits into
05-16-docs_misc_document_re-login_required_notification_after_main_keypair_changefrom
05-18-docs_fr-2912_document_docs-toolkit_build_web_and_serve_web_commands_in_readme
Open

docs(FR-2912): document web commands and fix preview:html sidebar scroll#7462
agatha197 wants to merge 4 commits into
05-16-docs_misc_document_re-login_required_notification_after_main_keypair_changefrom
05-18-docs_fr-2912_document_docs-toolkit_build_web_and_serve_web_commands_in_readme

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented May 18, 2026

Resolves #7461 (FR-2912)

Stacked on #7450 (docs(misc): document Re-Login Required notification after main keypair change).

Summary

Documentation update to the backend.ai-docs-toolkit package README, plus a small fix for the preview:html sidebar that broke after FR-2768.

README updates

  • Add docs-toolkit build:web and docs-toolkit serve:web to the usage block and the command table.
  • Expand Common Options: pdf --chapters/--note, build:web --strict/--no-strict/--optimize-images/--optimize-images-avif, and default ports for preview/preview:html/serve:web.
  • Add a generateWebsite example to the programmatic API section.
  • Clarify preview:html (no PDF) and add docs-toolkit help to the table.
  • Add a Troubleshooting: docs-toolkit: not found subsection — explains why pnpm skips the docs-toolkit bin symlink on fresh clones/worktrees (install runs before dist/cli.js is built), why pnpm install/--force does not fix it ("Already up to date" skips bin-linking), and the pnpm --filter <docs-pkg> rebuild fix plus a verify command.

preview:html sidebar fix

  • Wrap the nav list in .doc-sidebar__scroll in html-builder-web.ts to mirror website-builder.ts. FR-2768 made .doc-sidebar a fixed-height overflow:hidden flex column and delegated scrolling to an inner .doc-sidebar__scroll element (styles-web.ts). website-builder.ts (build:web/serve:web) emits that wrapper, but the legacy single-page preview builder (html-builder-web.ts, used by preview:html/preview:html:ko) was never updated, so the nav overflowed a clipped container with no scrollport and the sidebar could not scroll.

Copy link
Copy Markdown
Contributor Author

agatha197 commented May 18, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 changed the title docs(FR-2912): document docs-toolkit build:web and serve:web commands in README docs(FR-2912): document docs-toolkit build:web/serve:web commands and troubleshooting in README May 18, 2026
@agatha197 agatha197 force-pushed the 05-16-docs_misc_document_re-login_required_notification_after_main_keypair_change branch from 3e737ea to f5d41b7 Compare May 18, 2026 07:17
@agatha197 agatha197 force-pushed the 05-18-docs_fr-2912_document_docs-toolkit_build_web_and_serve_web_commands_in_readme branch from e4af0ea to d7272a8 Compare May 18, 2026 07:17
agatha197 and others added 3 commits May 18, 2026 16:29
FR-2768 made .doc-sidebar a fixed-height, overflow:hidden flex column
and delegated scrolling to an inner .doc-sidebar__scroll element in
styles-web.ts. website-builder.ts (build:web / serve:web) emits that
wrapper, but the legacy single-page preview builder (html-builder-web.ts,
used by preview:html / preview:html:ko) was never updated, so the nav
overflowed a clipped container with no scrollport and the sidebar could
not scroll.

Wrap the nav list in .doc-sidebar__scroll to mirror website-builder.ts,
restoring sidebar scrolling in the HTML preview server.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…README

New clones / git worktrees run `pnpm install` before the toolkit's
`dist/cli.js` exists, so pnpm skips creating the `docs-toolkit` bin
symlink and every `docs-toolkit ...` script fails with `not found`.
Document the cause and the `pnpm --filter <docs-pkg> rebuild` fix
(since `pnpm install`/`--force` report "Already up to date" and skip
bin-linking).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@agatha197 agatha197 force-pushed the 05-16-docs_misc_document_re-login_required_notification_after_main_keypair_change branch from f5d41b7 to e775331 Compare May 18, 2026 07:30
@agatha197 agatha197 force-pushed the 05-18-docs_fr-2912_document_docs-toolkit_build_web_and_serve_web_commands_in_readme branch from d7272a8 to 2755b1a Compare May 18, 2026 07:30
@agatha197 agatha197 marked this pull request as ready for review May 18, 2026 07:31
Copilot AI review requested due to automatic review settings May 18, 2026 07:31
@agatha197 agatha197 changed the title docs(FR-2912): document docs-toolkit build:web/serve:web commands and troubleshooting in README docs(FR-2912): document web commands and fix preview:html sidebar scroll May 18, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Backend.AI docs toolkit documentation for static website commands and related troubleshooting, while also including a small generated HTML structure change for the web preview sidebar.

Changes:

  • Documents build:web, serve:web, common CLI options, default ports, and troubleshooting for missing docs-toolkit bin links.
  • Adds generateWebsite to the programmatic API example.
  • Wraps the single-page HTML preview sidebar nav in .doc-sidebar__scroll.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
packages/backend.ai-docs-toolkit/README.md Expands CLI usage, options, troubleshooting, and API examples.
packages/backend.ai-docs-toolkit/src/html-builder-web.ts Updates sidebar markup to match the scroll container structure used by website builds.

Comment thread packages/backend.ai-docs-toolkit/src/html-builder-web.ts
Comment thread packages/backend.ai-docs-toolkit/src/html-builder-web.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M 30~100 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants