Skip to content

docs(model-serving): capture endpoint detail ready-alert and replica-filter screenshots#7459

Open
agatha197 wants to merge 1 commit into
05-15-docs_model-serving_update_for_deployment-only_create_modal_revision_ux_and_detail_page_polishfrom
05-18-docs_model-serving_capture_endpoint_detail_ready-alert_and_replica-filter_screenshots
Open

docs(model-serving): capture endpoint detail ready-alert and replica-filter screenshots#7459
agatha197 wants to merge 1 commit into
05-15-docs_model-serving_update_for_deployment-only_create_modal_revision_ux_and_detail_page_polishfrom
05-18-docs_model-serving_capture_endpoint_detail_ready-alert_and_replica-filter_screenshots

Conversation

@agatha197
Copy link
Copy Markdown
Contributor

@agatha197 agatha197 commented May 18, 2026

Stacked on #7443 (docs(model-serving): update for deployment-only create modal, revision UX, and detail page polish).

Follow-up polish that resolves the screenshot TODO placeholders introduced by #7443 in model_serving.md. No separate issue (small completion of #7443's own scope).

Summary

  • Captured endpoint_detail_ready_alert.png and replica_status_filter.png from the live WebUI on a healthy deployment, in all 4 locales (en/ja/ko/th), at 2× zoom via window.switchLanguage per SCREENSHOT-GUIDELINES.md.
  • Removed the 2 corresponding <!-- TODO: Capture screenshot — ... --> comments in src/{en,ja,ko,th}/model_serving/model_serving.md (8 lines total). Image references and surrounding blank lines unchanged.

Intentionally left as-is

Notes for #7443 author

  • The ready-alert section describes a "Start Chat" button, but the actual UI button is "Test in Chat" (visible in the new screenshot). Prose-only fix, out of scope for this PR.

Test plan

  • src/{en,ja,ko,th}/images/endpoint_detail_ready_alert.png and replica_status_filter.png render in the manual.
  • Each locale's screenshot shows that locale's UI strings.
  • Only the SHM + cross-reference TODOs remain in model_serving.md.

🤖 Generated with Claude Code

Copy link
Copy Markdown
Contributor Author

agatha197 commented May 18, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent changes, fast-track this PR to the front of the merge queue

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 marked this pull request as ready for review May 18, 2026 05:22
Copilot AI review requested due to automatic review settings May 18, 2026 05:22
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes screenshot TODO placeholders in the model-serving user manual after the corresponding screenshots (endpoint_detail_ready_alert.png and replica_status_filter.png) were captured for all four locales. It is a small follow-up to PR #7443.

Changes:

  • Removes two <!-- TODO: Capture screenshot — ... --> HTML comments per locale, now that the referenced images exist.
  • Applied identically to en/ja/ko/th versions of model_serving.md.

Reviewed changes

Copilot reviewed 4 out of 12 changed files in this pull request and generated no comments.

File Description
packages/backend.ai-webui-docs/src/en/model_serving/model_serving.md Removes two screenshot TODO comments
packages/backend.ai-webui-docs/src/ja/model_serving/model_serving.md Removes two screenshot TODO comments
packages/backend.ai-webui-docs/src/ko/model_serving/model_serving.md Removes two screenshot TODO comments
packages/backend.ai-webui-docs/src/th/model_serving/model_serving.md Removes two screenshot TODO comments

@agatha197 agatha197 changed the base branch from 05-15-docs_model-serving_update_for_deployment-only_create_modal_revision_ux_and_detail_page_polish to graphite-base/7459 May 18, 2026 06:29
@agatha197 agatha197 deleted the branch 05-15-docs_model-serving_update_for_deployment-only_create_modal_revision_ux_and_detail_page_polish May 18, 2026 06:45
@agatha197 agatha197 closed this May 18, 2026
@agatha197 agatha197 reopened this May 18, 2026
@agatha197 agatha197 changed the base branch from graphite-base/7459 to 05-15-docs_model-serving_update_for_deployment-only_create_modal_revision_ux_and_detail_page_polish May 18, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS ~10 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants