Skip to content

[wpimath] Add Input Type support to Feedforward classes (c++) #7908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 43 commits into
base: 2027
Choose a base branch
from
Open

[wpimath] Add Input Type support to Feedforward classes (c++) #7908

wants to merge 43 commits into from
+983 −635

Conversation

narmstro2020
Copy link
Contributor

Adds Input type to Feedforward

@narmstro2020 narmstro2020 requested a review from a team as a code owner April 16, 2025 02:25
@github-actions github-actions bot added component: wpimath Math library 2027 2027 target labels Apr 16, 2025
calcmogul
calcmogul requested changes Apr 16, 2025
View reviewed changes
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of unrelated changes here to revert.

@narmstro2020
Copy link
Contributor Author

There's a lot of unrelated changes here to revert.

Were you referring to this or the PR I just closed?

@calcmogul
Copy link
Member

This PR.

@narmstro2020
Copy link
Contributor Author

This PR.

Referring to the other files now requiring an Input template parameter?

@narmstro2020
Copy link
Contributor Author

@calcmogul
Sorry I'm a little confused. I only have 1 file that is being changed currently.

@calcmogul
Copy link
Member

There's implementation changes unrelated to this PR and an added deprecated function in SimpleMotorFeedforward that shouldn't be there.

@narmstro2020
Copy link
Contributor Author

There's implementation changes unrelated to this PR and an added deprecated function in SimpleMotorFeedforward that shouldn't be there.

Oh I see. This originated in main and not 2027. I will fix.

@narmstro2020 narmstro2020 requested review from a team as code owners April 16, 2025 12:40
@narmstro2020
Copy link
Contributor Author

We should add extra tests for each input unit so the compiler actually instantiates the template to check it for errors or things we missed. That includes the feedforward tests and the struct serialization tests.

Excellent. Should the examples that use these be templated as well?

@narmstro2020
Copy link
Contributor Author

narmstro2020 commented Apr 17, 2025 •
edited
Loading

@calcmogul

I think the tests are good now.

@narmstro2020 narmstro2020 requested a review from calcmogul April 17, 2025 14:18
calcmogul
calcmogul requested changes Apr 17, 2025
View reviewed changes
@narmstro2020
Copy link
Contributor Author

@calcmogul

Would these tests for CheckSize do the trick?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calcmogul calcmogul calcmogul requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
2027 2027 target component: command-based WPILib Command Based Library component: examples component: wpilibc WPILib C++ component: wpimath Math library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@narmstro2020 @calcmogul