[core-api][experimental] Definitions.merge
#26704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
94f89e3 to
25d1bd6
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
042185a to
d096946
Compare
yuhan
approved these changes
Dec 26, 2024
|
This one I am not totally sold on yet since components might in fact hide this forever since it called on the user's behalf. |
Merged
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
25d1bd6 to
632d3a9
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
d096946 to
beab8e1
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
632d3a9 to
b534d44
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
beab8e1 to
490e571
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
b534d44 to
7bec214
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
490e571 to
ff38870
Compare
schrockn
previously requested changes
Jan 2, 2025
OwenKephart
force-pushed
the
12-23-_core-api_experimental_create_repository_using_definitions_args_
branch
from
7bec214 to
433b506
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
ff38870 to
e938ec3
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_create_repository_using_definitions_args_
to
12-23-_core-api_experimental_dataversion_assorted_apis
OwenKephart
force-pushed
the
12-23-_core-api_experimental_dataversion_assorted_apis
branch
from
e88962e to
fb36ffb
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
e938ec3 to
c84b092
Compare
@schrockn Do you think the beta stage would make more sense? Would we deprecate/delete this when components are around, or would users leverage |
|
We are going to need to support something like it so let's move forward with exposing it. |
maximearmstrong
approved these changes
Feb 5, 2025
OwenKephart
force-pushed
the
12-23-_core-api_experimental_dataversion_assorted_apis
branch
from
fb36ffb to
be302f9
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
c84b092 to
1d59b23
Compare
## Summary & Motivation decision: experimental -> public reason: doubt many people are using this, but it has existed for many many years and there is no reason for us to remove support for it docs exist: yes (api only, which is ok) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit 29bac57
into
12-23-_core-api_experimental_dataversion_assorted_apis
1 check was pending
OwenKephart
deleted the
12-23-_core-api_experimental_definitions.merge_
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: we are leaning heavily on this behavior in components-land, and generally see this as a good tool when organizing a code location. we should formally endorse it
docs exist: no (will likely need to create some sort of guide along the lines of "organizing code locations", which would reference this)
How I Tested These Changes
Changelog