[core-api] base #26770
Merged
[core-api] base #26770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 31, 2024
This was referenced Dec 31, 2024
OwenKephart
force-pushed
the
core-api-audit
branch
from
efa7c18 to
28e73c5
Compare
OwenKephart
force-pushed
the
core-api-audit
branch
2 times, most recently
from
655ae75 to
f2e00af
Compare
OwenKephart
force-pushed
the
core-api-audit
branch
from
f2e00af to
7a526b2
Compare
#26707) decision: experimental -> beta reason: we might want to subtly change the default behavior of this (e.g. how far down the tree it looks) docs exist: n/a > Insert changelog entry or delete this section.
OwenKephart
force-pushed
the
core-api-audit
branch
from
803c15e to
7988612
Compare
## Summary & Motivation decision: experimental -> public (uncertain) reason: this has existed for years without change. even if this is not a commonly-used API, we should probably just make the call that we're not changing it at this point docs exist: yes (api only, which is ok) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
force-pushed
the
core-api-audit
branch
from
7988612 to
04f8f45
Compare
maximearmstrong
approved these changes
Feb 6, 2025
| @@ -241,7 +241,7 @@ def groups(*group_strs, include_sources: bool = False) -> "GroupsAssetSelection" | |||
|
|
|||
| @public | |||
| @staticmethod | |||
| @experimental | |||
| @experimental_param(param="include_sources") | |||
There was a problem hiding this comment.
Could we use @beta_param here?
| @whitelist_for_serdes( | ||
| old_fields={"time_window_partition_scope_minutes": 1e-6}, | ||
| serializer=AutoMaterializePolicySerializer, | ||
| ) | ||
| @deprecated(breaking_version="1.10.0") |
There was a problem hiding this comment.
[1] Should we add a message, maybe suggesting DA?
| @@ -211,7 +211,7 @@ def evaluate_for_asset(self, context: "AutomationContext") -> "AutomationResult" | |||
|
|
|||
|
|
|||
| @whitelist_for_serdes | |||
| @experimental | |||
| @deprecated(breaking_version="1.10.0") | |||
…26710) ## Summary & Motivation decision: experimental -> GA (after parameter change) reason: if we're going to make this change, we should acompany it with marking this API as stable (i.e. we should only make the name change once). "source assets" as a concept no longer really exist, and external assets is the more general term (and more accurate to what these parameters were actually filtering for. docs exist: yes (api only, which is ok) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
added a commit
that referenced
this pull request
Feb 8, 2025
This reverts commit 133b1a8.
deepyaman
pushed a commit
that referenced
this pull request
Feb 10, 2025
## Summary & Motivation This is the base of the core-api-audit stack. The entire stack will be merged in at the 1.10 release, and for now to keep things tidy, changes will be merged downwards as they are approved. This means that this PR contains only code that has been reviewed and approved in a different PR. ## How I Tested These Changes ## Changelog The `include_sources` param on all `AssetSelection` APIs has been renamed to `include_external_assets`.
maximearmstrong
added a commit
that referenced
this pull request
Feb 11, 2025
## Summary & Motivation As title. This PR is pending the merged of PR #26770.
deepyaman
pushed a commit
that referenced
this pull request
Feb 11, 2025
## Summary & Motivation As title. This PR is pending the merged of PR #26770.
LoHertel
pushed a commit
to LoHertel/dagster
that referenced
this pull request
Feb 11, 2025
## Summary & Motivation This is the base of the core-api-audit stack. The entire stack will be merged in at the 1.10 release, and for now to keep things tidy, changes will be merged downwards as they are approved. This means that this PR contains only code that has been reviewed and approved in a different PR. ## How I Tested These Changes ## Changelog The `include_sources` param on all `AssetSelection` APIs has been renamed to `include_external_assets`.
LoHertel
pushed a commit
to LoHertel/dagster
that referenced
this pull request
Feb 11, 2025
) ## Summary & Motivation As title. This PR is pending the merged of PR dagster-io#26770.
braunjj
pushed a commit
that referenced
this pull request
Feb 14, 2025
## Summary & Motivation This is the base of the core-api-audit stack. The entire stack will be merged in at the 1.10 release, and for now to keep things tidy, changes will be merged downwards as they are approved. This means that this PR contains only code that has been reviewed and approved in a different PR. ## How I Tested These Changes ## Changelog The `include_sources` param on all `AssetSelection` APIs has been renamed to `include_external_assets`.
braunjj
pushed a commit
that referenced
this pull request
Feb 14, 2025
## Summary & Motivation As title. This PR is pending the merged of PR #26770.
brentjericho
pushed a commit
to brentjericho/dagster
that referenced
this pull request
Feb 21, 2025
## Summary & Motivation This is the base of the core-api-audit stack. The entire stack will be merged in at the 1.10 release, and for now to keep things tidy, changes will be merged downwards as they are approved. This means that this PR contains only code that has been reviewed and approved in a different PR. ## How I Tested These Changes ## Changelog The `include_sources` param on all `AssetSelection` APIs has been renamed to `include_external_assets`.
brentjericho
pushed a commit
to brentjericho/dagster
that referenced
this pull request
Feb 21, 2025
) ## Summary & Motivation As title. This PR is pending the merged of PR dagster-io#26770.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
This is the base of the core-api-audit stack. The entire stack will be merged in at the 1.10 release, and for now to keep things tidy, changes will be merged downwards as they are approved.
This means that this PR contains only code that has been reviewed and approved in a different PR.
How I Tested These Changes
Changelog
The
include_sourcesparam on allAssetSelectionAPIs has been renamed toinclude_external_assets.