[core-api][experimental] Definitions.get_all_asset_specs, Definitions.with_reconstruction_metadata #26705
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
changed the title
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
042185a to
d096946
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
991c6c0 to
73e3a15
Compare
yuhan
previously requested changes
Dec 26, 2024
Merged
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
d096946 to
beab8e1
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
73e3a15 to
9712a54
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_definitions.merge_
branch
from
beab8e1 to
490e571
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
9712a54 to
b1446c6
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_definitions.merge_
to
12-23-_core-api_experimental_execution_type
OwenKephart
force-pushed
the
12-23-_core-api_experimental_execution_type
branch
from
d00d951 to
9d0fffe
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
b1446c6 to
2487afe
Compare
|
updated! |
OwenKephart
force-pushed
the
12-23-_core-api_experimental_execution_type
branch
from
9d0fffe to
3a73704
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
2487afe to
bb9ad96
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_execution_type
to
12-23-_core-api_experimental_custom_path_fs_io_manager_
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
ffa35ac to
4fc73c3
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
bb9ad96 to
adea27f
Compare
maximearmstrong
approved these changes
Feb 5, 2025
…s.with_reconstruction_metadata
OwenKephart
force-pushed
the
12-23-_core-api_experimental_custom_path_fs_io_manager_
branch
from
4fc73c3 to
dfedc60
Compare
OwenKephart
force-pushed
the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
from
adea27f to
0245369
Compare
…26709) ## Summary & Motivation decision: experimental -> beta reason: this is an unfortunate case where a fairly-new option actually ended up needing to reference the superseded repository API. we should fix that before making this GA (and this is a fairly niche option) docs exist: n/a ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit ea1d6a5
into
12-23-_core-api_experimental_custom_path_fs_io_manager_
1 check was pending
OwenKephart
deleted the
12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> beta
reason: these seem a bit more speculative --
get_all_asset_specs()has somewhat unituitive behavior asDefinitions(assets=[AssetSpec("a", deps="b")]).get_all_asset_specs()actually returns two specs. the reconstruction metadata bit also feels subject to change in the futuredocs exist: n/a
How I Tested These Changes
Changelog