Skip to content

[core-api][experimental] freshness_policy param #26702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> deprecated
reason: FreshnessPolicy is deprecated
docs exist: n/a

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looksgood

@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_observeresult branch from a44d76a to 2fcbc04 Compare December 31, 2024 18:48
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from c2b91ad to 49e2b30 Compare December 31, 2024 18:48
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:52
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_observeresult branch from 2fcbc04 to 020b0d3 Compare December 31, 2024 19:17
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from 49e2b30 to 4d3f937 Compare December 31, 2024 19:19
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_observeresult to 12-23-_core-api_experimental_custom_path_fs_io_manager_ December 31, 2024 19:19
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_custom_path_fs_io_manager_ branch from d6685c8 to bbb30b2 Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from 4d3f937 to 7ab92ce Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from 7ab92ce to 66846ba Compare January 18, 2025 00:54
@OwenKephart OwenKephart requested a review from neverett as a code owner January 18, 2025 00:54
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_custom_path_fs_io_manager_ to 12-23-_core-api_experimental_create_repository_using_definitions_args_ January 18, 2025 00:54
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_create_repository_using_definitions_args_ branch from 433b506 to 927bee5 Compare January 18, 2025 00:59
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from 66846ba to cc49cf0 Compare January 18, 2025 00:59
@neverett neverett removed their request for review January 29, 2025 17:53
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_create_repository_using_definitions_args_ branch from 927bee5 to d52d98f Compare February 6, 2025 21:40
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_freshness_policy_param branch from cc49cf0 to a5416ff Compare February 6, 2025 21:40
## Summary & Motivation

decision: experimental -> beta
reason: we will likely retain some version of this parameter, but low
confidence on this being the final name / form
docs: n/a

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.
@OwenKephart OwenKephart merged commit e6e2a26 into 12-23-_core-api_experimental_create_repository_using_definitions_args_ Feb 6, 2025
1 check was pending
@OwenKephart OwenKephart deleted the 12-23-_core-api_experimental_freshness_policy_param branch February 6, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants