Skip to content

[core-api][experimental] BackfillPolicy #26694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

OwenKephart
Copy link
Contributor

@OwenKephart OwenKephart commented Dec 23, 2024

Summary & Motivation

decision: experimental -> beta
reason: this requires a final pass on our end to feel comfortable marking as GA, but I think it is worth doing in the near future as this is a powerful feature
docs exist: no (will need to)

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

Copy link
Contributor

@jamiedemaria jamiedemaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_source_code_metadata branch from 6fc2844 to 1138493 Compare December 23, 2024 21:55
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 9ebd887 to e6c0b94 Compare December 23, 2024 21:55
@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_source_code_metadata branch from 1138493 to 24973f3 Compare December 31, 2024 18:47
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from e6c0b94 to 5fa3ac5 Compare December 31, 2024 18:47
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:51
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_source_code_metadata branch from 24973f3 to e6d2012 Compare December 31, 2024 19:17
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 5fa3ac5 to e3b0934 Compare December 31, 2024 19:19
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_source_code_metadata to 12-23-_core-api_experimental_placeholder_create_beta_decorator December 31, 2024 19:19
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_placeholder_create_beta_decorator branch from a9f734c to d912535 Compare December 31, 2024 19:30
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from e3b0934 to 2945f86 Compare December 31, 2024 19:30
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_placeholder_create_beta_decorator branch from d912535 to 56c3edd Compare January 18, 2025 00:53
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 2945f86 to 704f583 Compare January 18, 2025 00:54
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_placeholder_create_beta_decorator to 12-23-_core-api_experimental_get_asset_provenance_ January 18, 2025 00:54
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_get_asset_provenance_ branch from 6b1aae6 to d243e7e Compare January 18, 2025 00:58
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 704f583 to 22e8a29 Compare January 18, 2025 00:59
Copy link
Contributor

@maximearmstrong maximearmstrong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the usage of the new @beta_param

@@ -1050,3 +1050,6 @@ def only_allow_hidden_params_in_kwargs(annotatable: Annotatable, kwargs: Mapping
deprecated_params[param].hidden,
f"Unexpected non-hidden deprecated parameter '{param}' in kwargs. Should never get here.",
)


beta_param = experimental_param # PLACEHOLDER
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have the beta param now #27227

@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_get_asset_provenance_ branch from d243e7e to 74478c0 Compare February 6, 2025 21:39
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_backfillpolicy branch from 22e8a29 to 2e3066c Compare February 6, 2025 21:40
…26703)

## Summary & Motivation

decision: experimental -> GA
reason: this is a bit of glue code for users still using `@repository`,
but there's no reason to delete it and we have no plans of changing it
(plus it has existed for years).
docs exist: yes (api only, which is ok)

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.
@OwenKephart OwenKephart merged commit ab5f388 into 12-23-_core-api_experimental_get_asset_provenance_ Feb 6, 2025
1 check was pending
@OwenKephart OwenKephart deleted the 12-23-_core-api_experimental_backfillpolicy branch February 6, 2025 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants