[core-api][experimental] AssetSelection.tag #26697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
OwenKephart
force-pushed
the
12-23-_core-api_experimental_automationconditionsensordefinition
branch
from
bfade49 to
a9b8112
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
e4d88f7 to
f66e7e5
Compare
yuhan
reviewed
Dec 26, 2024
| @@ -240,7 +240,7 @@ def groups(*group_strs, include_sources: bool = False) -> "GroupsAssetSelection" | |||
|
|
|||
| @public | |||
| @staticmethod | |||
| @experimental | |||
| @experimental_param(param="include_sources") | |||
There was a problem hiding this comment.
I make it not experimental upstack
Merged
OwenKephart
force-pushed
the
12-23-_core-api_experimental_automationconditionsensordefinition
branch
from
a9b8112 to
01dc421
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
f66e7e5 to
cfcadea
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_automationconditionsensordefinition
branch
from
01dc421 to
97c20c1
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
cfcadea to
e7362d3
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_automationconditionsensordefinition
to
12-23-_core-api_experimental_table_metadata
OwenKephart
force-pushed
the
12-23-_core-api_experimental_table_metadata
branch
from
bdb8f2c to
058bd67
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
e7362d3 to
709d87e
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_table_metadata
branch
from
058bd67 to
97d91ef
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
709d87e to
4e9070f
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_table_metadata
branch
from
97d91ef to
08c1268
Compare
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
4e9070f to
654f5e5
Compare
maximearmstrong
approved these changes
Feb 5, 2025
OwenKephart
force-pushed
the
12-23-_core-api_experimental_assetselection.tag
branch
from
654f5e5 to
3512497
Compare
OwenKephart
changed the base branch from
12-23-_core-api_experimental_table_metadata
to
12-23-_core-api_experimental_direct_resource_passing
## Summary & Motivation decision: experimental -> beta reason: many of these APIs have not been publicized and are not part of core code paths. want to retain the option of changing the naming / structure in the future docs exist: n/a (but no) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
OwenKephart
merged commit 1a963db
into
12-23-_core-api_experimental_direct_resource_passing
1 check was pending
OwenKephart
deleted the
12-23-_core-api_experimental_assetselection.tag
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> GA
reason: this has existed for a long time, we need to support it for the new asset selection syntax, and there's no reason that we would not want to support this behavior
docs exist: yes (API only, which is ok)
How I Tested These Changes
Changelog