-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[core-api][experimental] DataVersion assorted APIs #26698
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
OwenKephart
merged 2 commits into
12-23-_core-api_experimental_assetselection.tag
from
12-23-_core-api_experimental_dataversion_assorted_apis
Feb 6, 2025
Merged
[core-api][experimental] DataVersion assorted APIs #26698
OwenKephart
merged 2 commits into
12-23-_core-api_experimental_assetselection.tag
from
12-23-_core-api_experimental_dataversion_assorted_apis
Feb 6, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
This was referenced Dec 23, 2024
e4d88f7
to
f66e7e5
Compare
e1541b6
to
6aaa345
Compare
yuhan
previously requested changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be in "Preview"/alpha then?
Merged
f66e7e5
to
cfcadea
Compare
6aaa345
to
16083d3
Compare
cfcadea
to
e7362d3
Compare
16083d3
to
bc43343
Compare
e7362d3
to
709d87e
Compare
bc43343
to
fe518fd
Compare
imo, preview = "in active development and will change often", and we're not planning any changes to this API in the immediate future |
709d87e
to
4e9070f
Compare
fe518fd
to
e88962e
Compare
4e9070f
to
654f5e5
Compare
e88962e
to
fb36ffb
Compare
maximearmstrong
approved these changes
Feb 5, 2025
654f5e5
to
3512497
Compare
fb36ffb
to
be302f9
Compare
## Summary & Motivation decision: experimental -> GA reason: we are leaning heavily on this behavior in components-land, and generally see this as a good tool when organizing a code location. we should formally endorse it docs exist: no (will likely need to create some sort of guide along the lines of "organizing code locations", which would reference this) ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
c170bd8
into
12-23-_core-api_experimental_assetselection.tag
1 check was pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
decision: experimental -> beta
reason: many of these APIs have not been publicized and are not part of core code paths. want to retain the option of changing the naming / structure in the future
docs exist: n/a (but no)
How I Tested These Changes
Changelog