Skip to content

[21358] Fix null-dereference error on Ubuntu#5895

Merged
MiguelCompany merged 9 commits into
masterfrom
hotfix/ubunyu-ci-null-deprecated
Jul 3, 2025
Merged

[21358] Fix null-dereference error on Ubuntu#5895
MiguelCompany merged 9 commits into
masterfrom
hotfix/ubunyu-ci-null-deprecated

Conversation

@Javgilavi

@Javgilavi Javgilavi commented Jun 20, 2025 •
edited by cferreiragonz
Loading

Copy link
Copy Markdown
Contributor

Description

This PR add the -Wnull-dereference to the Alternative Build on Ubuntu's CI and the fixed needed after this warning/errors.

This PR depends on:

and must be merged after that one.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Javgilavi Javgilavi added this to the v3.3.0 milestone Jun 20, 2025
@Javgilavi
Javgilavi requested a review from richiprosima June 20, 2025 08:13
@github-actions github-actions Bot added the ci-pending PR which CI is running label Jun 20, 2025
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch 3 times, most recently from d979d8f to ba4b5fa Compare June 20, 2025 13:22
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 20, 2025 13:23
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from ba4b5fa to 92d4758 Compare June 20, 2025 13:29
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 20, 2025 13:29
@Javgilavi
Javgilavi force-pushed the hotfix/ubuntu-ci-restrictive-tags branch from f4bfd05 to 2564f62 Compare June 23, 2025 05:47
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from 92d4758 to 0aa97fe Compare June 23, 2025 05:48
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 23, 2025 05:49
@rsanchez15 rsanchez15 changed the title [21358] Fix null-deprecated error on Ubuntu [21358] Fix null-dereference error on Ubuntu Jun 23, 2025
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from d3d90aa to 902252b Compare June 23, 2025 08:15
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 23, 2025 08:15
Base automatically changed from hotfix/ubuntu-ci-restrictive-tags to master June 24, 2025 06:24
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch 2 times, most recently from 54c2683 to 02d70c1 Compare June 24, 2025 07:55
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 24, 2025 07:56
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from 02d70c1 to fae8d8f Compare June 24, 2025 08:26
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 24, 2025 08:26
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from fae8d8f to 2b3f85e Compare June 24, 2025 08:41
@Javgilavi
Javgilavi requested review from richiprosima and removed request for richiprosima June 24, 2025 08:42
cferreiragonz
cferreiragonz requested changes Jul 2, 2025
View reviewed changes

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last round

Comment thread src/cpp/fastdds/xtypes/dynamic_types/DynamicDataImpl.hpp Outdated
Comment thread src/cpp/fastdds/xtypes/dynamic_types/DynamicTypeBuilderImpl.cpp Outdated
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from 314e24b to 39e53dc Compare July 2, 2025 06:14
@Javgilavi
Javgilavi requested a review from cferreiragonz July 2, 2025 06:15
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from 39e53dc to d123b9b Compare July 2, 2025 06:18
@Javgilavi
Javgilavi requested review from cferreiragonz and removed request for cferreiragonz July 2, 2025 06:22
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from d123b9b to a298c68 Compare July 2, 2025 06:29
@Javgilavi
Javgilavi requested review from cferreiragonz and removed request for cferreiragonz July 2, 2025 06:29
@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from a298c68 to 7024d4f Compare July 2, 2025 07:57
@Javgilavi
Javgilavi requested review from cferreiragonz and removed request for cferreiragonz July 2, 2025 07:57
cferreiragonz
cferreiragonz previously approved these changes Jul 2, 2025
View reviewed changes

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Javgilavi
Javgilavi force-pushed the hotfix/ubunyu-ci-null-deprecated branch from 7024d4f to 6f3a3ee Compare July 2, 2025 09:22
@cferreiragonz

cferreiragonz commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

@Mergifyio rebase master

Javier Gil Aviles added 9 commits July 3, 2025 08:20
Javier Gil Aviles @cferreiragonz
Refs #21358: Fix null-deprecated error
aa69ac4 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #21358: Change null dereference compilation to test on alternati…
47c8007 
…ves build

Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #21358: Assert correctiosn fro tests
82e22df 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #Refs #21358: Correct getLocalParticipantProxyData assert missplace
20f264d 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #21358: Final corrections
5ae96c1 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #21358: Apply review corrections
4092724 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs 21358: Apply seconds review changes
0822f4a 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #21358: Limit gnu::optimize to Ubuntu
2378c75 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
Javier Gil Aviles @cferreiragonz
Refs #21358: Delate assert(false) and add log error
db72d35 
Signed-off-by: Javier Gil Aviles <javiergil@eprosima.com>
@mergify

mergify Bot commented Jul 3, 2025

Copy link
Copy Markdown
Contributor

rebase master

✅ Branch has been successfully rebased

@cferreiragonz
cferreiragonz force-pushed the hotfix/ubunyu-ci-null-deprecated branch from 6f3a3ee to db72d35 Compare July 3, 2025 08:20
@cferreiragonz
cferreiragonz self-requested a review July 3, 2025 08:20
cferreiragonz
cferreiragonz approved these changes Jul 3, 2025
View reviewed changes

@cferreiragonz cferreiragonz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cferreiragonz cferreiragonz cferreiragonz approved these changes

Assignees

No one assigned

Labels

ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.

Projects

None yet

Milestone

v3.3.0 - Frozen ❄️

Development

Successfully merging this pull request may close these issues.

3 participants

@Javgilavi @cferreiragonz @MiguelCompany