Skip to content

[core-api][experimental] allow_nonexistent_upstream_partitions #26708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> beta
reason: this is a fairly niche option, and we might want to change the name in the future
docs exist: n/a

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

This was referenced Dec 23, 2024
yuhan
yuhan previously requested changes Dec 26, 2024
Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preview instead? im honestly not sure if we have good validation on this one.

@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_automationcondition.any_downstream_conditions branch from 676e8d0 to 8b03dc6 Compare December 31, 2024 18:48
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 9e18b12 to 011b975 Compare December 31, 2024 18:48
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:52
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_automationcondition.any_downstream_conditions branch from 8b03dc6 to ac72e5b Compare December 31, 2024 19:17
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 011b975 to 65062e3 Compare December 31, 2024 19:20
@OwenKephart OwenKephart changed the base branch from 12-23-_core-apis_experimental_automationcondition.any_downstream_conditions to 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset December 31, 2024 19:20
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from 6af0044 to d182b8f Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 65062e3 to 442f718 Compare December 31, 2024 19:31
Copy link
Contributor Author

I think "preview" should be reserved for APIs that are actively changing -- this parameter has existed for awhile and while I'm not confident that it'll stick around in this form forever I can't see it changing any time soon

@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from d182b8f to 31e3975 Compare January 18, 2025 00:56
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 442f718 to b267283 Compare January 18, 2025 00:56
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from 31e3975 to fc75690 Compare January 18, 2025 01:04
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from b267283 to 0980841 Compare January 18, 2025 01:04
@maximearmstrong
Copy link
Contributor

maximearmstrong commented Feb 5, 2025

I think "preview" should be reserved for APIs that are actively changing -- this parameter has existed for awhile and while I'm not confident that it'll stick around in this form forever I can't see it changing any time soon

@yuhan @OwenKephart Also, we don't have a preview_param decorator. I could see the value in having one - the beta_param would be used in most cases though. WDYT?

@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from fc75690 to d3c8055 Compare February 6, 2025 21:41
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 0980841 to 91df7a0 Compare February 6, 2025 21:41
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from d3c8055 to 14d08c9 Compare February 6, 2025 22:22
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 91df7a0 to 39d1942 Compare February 6, 2025 22:22
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from 14d08c9 to a9e1b79 Compare February 6, 2025 22:29
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 39d1942 to c873453 Compare February 6, 2025 22:29
@OwenKephart OwenKephart force-pushed the 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset branch from a9e1b79 to 46636b1 Compare February 6, 2025 22:54
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from c873453 to 5617cf7 Compare February 6, 2025 22:54
Copy link
Contributor

@yuhan yuhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beta sounds fine

## Summary & Motivation

decision: experimental -> GA
reason: this has existed for awhile, and has comprehensive docs, seems
unlikely that we would change it in any meaningful way
docs exist: yes

## How I Tested These Changes

## Changelog

> Insert changelog entry or delete this section.
@OwenKephart OwenKephart merged commit 4367d44 into 12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset Feb 7, 2025
1 check was pending
@OwenKephart OwenKephart deleted the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch February 7, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants