-
Notifications
You must be signed in to change notification settings - Fork 1.7k
[core-api][experimental] allow_nonexistent_upstream_partitions #26708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preview instead? im honestly not sure if we have good validation on this one.
676e8d0
to
8b03dc6
Compare
9e18b12
to
011b975
Compare
8b03dc6
to
ac72e5b
Compare
011b975
to
65062e3
Compare
6af0044
to
d182b8f
Compare
65062e3
to
442f718
Compare
I think "preview" should be reserved for APIs that are actively changing -- this parameter has existed for awhile and while I'm not confident that it'll stick around in this form forever I can't see it changing any time soon |
d182b8f
to
31e3975
Compare
442f718
to
b267283
Compare
31e3975
to
fc75690
Compare
b267283
to
0980841
Compare
@yuhan @OwenKephart Also, we don't have a |
fc75690
to
d3c8055
Compare
0980841
to
91df7a0
Compare
d3c8055
to
14d08c9
Compare
91df7a0
to
39d1942
Compare
14d08c9
to
a9e1b79
Compare
39d1942
to
c873453
Compare
a9e1b79
to
46636b1
Compare
c873453
to
5617cf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
beta sounds fine
## Summary & Motivation decision: experimental -> GA reason: this has existed for awhile, and has comprehensive docs, seems unlikely that we would change it in any meaningful way docs exist: yes ## How I Tested These Changes ## Changelog > Insert changelog entry or delete this section.
4367d44
into
12-23-_core-apis_experimental_observable_source_asset_multi_observable_source_asset
Summary & Motivation
decision: experimental -> beta
reason: this is a fairly niche option, and we might want to change the name in the future
docs exist: n/a
How I Tested These Changes
Changelog