Skip to content

[core-api][experimental] repository_def in RunStatusSensorDefinition #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

OwenKephart
Copy link
Contributor

Summary & Motivation

decision: experimental -> beta
reason: this is an unfortunate case where a fairly-new option actually ended up needing to reference the superseded repository API. we should fix that before making this GA (and this is a fairly niche option)
docs exist: n/a

How I Tested These Changes

Changelog

Insert changelog entry or delete this section.

This was referenced Dec 23, 2024
Copy link
Contributor

yuhan commented Dec 26, 2024

is renaming to some code location an option here? i think if we'd introduce a code-location friendly name, we may as well just deprecate this instead of moving to GA?

@OwenKephart OwenKephart mentioned this pull request Dec 31, 2024
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 9e18b12 to 011b975 Compare December 31, 2024 18:48
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch from 963472e to 4a7e5a7 Compare December 31, 2024 18:48
@OwenKephart OwenKephart marked this pull request as ready for review December 31, 2024 18:52
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 011b975 to 65062e3 Compare December 31, 2024 19:20
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch from 4a7e5a7 to 1338be1 Compare December 31, 2024 19:20
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 65062e3 to 442f718 Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch from 1338be1 to c22804c Compare December 31, 2024 19:31
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from 442f718 to b267283 Compare January 18, 2025 00:56
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch from c22804c to 61c4bcd Compare January 18, 2025 00:56
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions branch from b267283 to 0980841 Compare January 18, 2025 01:04
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch from 61c4bcd to e7e3685 Compare January 18, 2025 01:04
@OwenKephart OwenKephart force-pushed the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch from e7e3685 to 2611756 Compare February 6, 2025 21:41
@OwenKephart OwenKephart requested a review from neverett as a code owner February 6, 2025 21:41
@OwenKephart OwenKephart changed the base branch from 12-23-_core-api_experimental_allow_nonexistent_upstream_partitions to 12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata February 6, 2025 21:41
@OwenKephart OwenKephart merged commit 36a420f into 12-23-_core-apis_experimental_definitions.get_all_asset_specs_definitions.with_reconstruction_metadata Feb 6, 2025
1 of 3 checks passed
@OwenKephart OwenKephart deleted the 12-23-_core-api_experimental_repository_def_in_runstatussensordefinition branch February 6, 2025 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants